Comprehensive code quality improvements and bug fixes #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses 18 identified issues across R and C++ code to improve robustness, performance, consistency, and maintainability.
R Code Improvements (feature_selection.R, general_tools.R, star_solo_processing.R)
Performance & Efficiency
Robustness & Error Handling
Issue Replace
dplyrgrouping with fast data.table implementation, with optional strand grouping #5: Standardized error handling across all functionsIssue Adding the modification of version 1.0.3 #13: Added input validation for GTF files
Issue Adding the modifications for version 1.0.4 #14: Added dimension checks in get_pseudo_correlation()
Issue fixing the issue with openMP detection on linux #23: Added edge case handling in find_variable_events()
User Experience
Issue Release v1.0.0: Initial Stable Version of splikit #7: Standardized verbose parameter defaults to FALSE
Issue Add dependency declarations and auto‑install hook #15: Improved NA handling in get_pseudo_correlation()
C++ Code Improvements (src/*.cpp)
Code Quality & Maintainability
Issue Fix OpenMP support for cross-platform compatibility #8: Refactored deviance_gene.cpp to eliminate code duplication
Issue Join results in more than 2^31 rows #16: Added integer matrix support to row_variance.cpp
Error Handling & Reliability
User Experience
Build System Improvements
Cross-Platform Support
Issues Reviewed but Not Changed
Testing Notes
All changes maintain backward compatibility. No API breaking changes. Functions tested with toy datasets confirm expected behavior.
Files Modified
Total: 19 improvements across 7 files